fix: Change how replies are processed #4870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Modified Teams connector to improve message reply handling logic in backend/onyx/connectors/teams/connector.py, specifically addressing rate limiting concerns by distinguishing between None replies (failed retrievals) and empty replies (valid responses).
- Updated condition in
_collect_documents_for_channelfromif cre or not repliestoif cre or replies is Nonefor more precise error detection - Change prevents false error reporting when messages legitimately have no replies
- Helps handle rate limiting by treating
Noneresponses as failures while allowing empty reply lists
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
evan-onyx
approved these changes
Jun 11, 2025
Weves
approved these changes
Jun 11, 2025
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes how the
replies: list[..] | Nonevariable is processed. Previously, aNoneOR an empty list would hit the if-case and yield aConnectorFailure. With this PR, only the former hits the if-case.Addresses: https://linear.app/danswer/issue/DAN-2063/add-rate-limiting-to-ms-teams-connector-apis.
How Has This Been Tested?
Tests already written and are passing.