fix: Remove threading from Teams connector #4875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Removed parallel processing from Teams connector to address thread-safety issues with the underlying Teams library.
- Eliminated
parallel_yieldfrombackend/onyx/connectors/teams/connector.py, switching to sequential channel document processing - Change may impact performance but improves reliability by avoiding potential thread-safety exceptions
- Critical reliability fix with untested changes warrants careful review of sequential processing implementation
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
evan-onyx
approved these changes
Jun 11, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes threading from Teams connector. Specifically, the call to
parallel_yield. Was causing issues (@Weves thinks the Teams library may be thread-unsafe).Addresses: https://linear.app/danswer/issue/DAN-2077/remove-threading-from-teams-connector.
How Has This Been Tested?
Not tested...