cleanup: Edit logic for default entity-types population #4876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
raunakab
changed the title
raunakab
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Refactored the Knowledge Graph entity types population to improve architectural design and return values. The changes focus on better database session management and explicit data returns.
- Function
populate_default_entity_typesinbackend/onyx/kg/setup/kg_default_entity_definitions.pynow accepts db_session as parameter instead of creating internally - Changed return type from None to list of all entity types for better data visibility
- Added explicit template constant and improved vendor name validation
- Improved separation of concerns by breaking down into smaller functions
- Enforced proper db session handling in
backend/onyx/chat/process_message.pyby explicitly passing session parameter
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
Orbital-Web
reviewed
Jun 12, 2025
Orbital-Web
reviewed
Jun 12, 2025
Orbital-Web
reviewed
Jun 12, 2025
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
…#4876) * Edit logic for default entity-types population * Remove templatization in favour of function * Address comments on PR * Pull call out into its own binding * Address comments on PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates how the
populate_default_entity_typesfunction works internally, and what it returns. With this update, it returns all the entity-types (including the fresh, templatized defaults) which have been inserted into the DB.Addresses: https://linear.app/danswer/issue/DAN-2080/edit-how-populate-default-entity-types-works-and-what-it-returns.
How Has This Been Tested?
Not tested.