fix: kg answer streaming #4877
Merged
fix: kg answer streaming #4877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Streamlined answer streaming implementation by standardizing the mechanism across different LLM providers like Claude and OpenAI through the shared stream_llm_answer utility.
- Removed custom token streaming and manual stream writes from
backend/onyx/agents/agent_search/kb_search/nodes/d1_generate_answer.py - Eliminated unused reference results streaming code and unnecessary tokenizer logic
- Removed obsolete stream handling functions from
backend/onyx/agents/agent_search/kb_search/graph_utils.pyin favor of the shared utility - Fixed visual inconsistencies in streaming output, particularly noticeable with Claude's responses (bullet point formatting remains a Claude-specific issue)
2 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
raunakab
reviewed
Jun 11, 2025
backend/onyx/agents/agent_search/kb_search/nodes/d1_generate_answer.py
Outdated
Show resolved
Hide resolved
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* fix: answer streaming * fix: env vars * fix: remove duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed answer streaming, particularly for models like claude and made it standardized with the other streamings.
Before
After
(the bullet point not being right is a claude issue)
How Has This Been Tested?
Locally, with openai and claude
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.