Skip to content

Conversation

Orbital-Web
Copy link
Contributor

@Orbital-Web Orbital-Web commented Jun 12, 2025

Description

[Provide a brief description of the changes in this PR]

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

@Orbital-Web Orbital-Web marked this pull request as ready for review June 12, 2025 17:35
Copy link

vercel bot commented Jun 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2025 5:35pm

@Orbital-Web Orbital-Web requested a review from a team as a code owner June 12, 2025 17:35
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Fixed a critical variable name mismatch in knowledge graph extraction logic that was causing incorrect relationship count aggregation.

  • In backend/onyx/kg/extractions/extraction_processing.py, corrected undefined variable count to extraction_count for proper accumulation of relationship counts during batch KG extraction processing

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@raunakab raunakab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐🐐🐐

@raunakab raunakab enabled auto-merge June 12, 2025 17:53
@Orbital-Web Orbital-Web disabled auto-merge June 12, 2025 22:44
@Orbital-Web Orbital-Web merged commit b5fc1b4 into main Jun 12, 2025
10 of 12 checks passed
@Orbital-Web Orbital-Web deleted the kg-extraction-fix branch June 12, 2025 22:44
AnkitTukatek pushed a commit to TukaTek/onyx that referenced this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants