KG process email fix #4928
Closed
KG process email fix #4928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Improves email extraction from GitHub metadata by updating the knowledge graph utilities to handle complex email strings more robustly.
- Adds new
extract_emailfunction inbackend/onyx/kg/utils/formatting_utils.pyto properly parse emails from complex metadata strings - Removes
is_emailvalidation inbackend/onyx/kg/utils/extraction_utils.pyin favor of the more robustextract_emailapproach - Fixes incorrect name display issue where GitHub accounts had trailing '}' characters by properly extracting emails from attribute strings like
{name: John, email: johndoe@gmail.com}
3 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
Orbital-Web
force-pushed
the
kg-process-email-fix
branch
from
535f4f2 to
6fa6fc1
Compare
|
Will be part of antoher pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Accounts extracted from GitHub attributes were showing up weird because of the way emails are shown in the metadata. This now extracts the email portion before passing it into the process_email function, rather than passing the whole string and treating everything before the @ as the name and after as the domain.
Now, even if the attribute looks like {'name' John, 'email': johndoe@gmail.com}, the correct name and domain will be extracted. Same goes with any arbitrary string that contains an email.
How Has This Been Tested?
Without this PR:
Accounts extracted from GitHub have a weird } at the end. You'd have to test this on a repo with users that display their email.
With this PR:
The name and account should look correct.
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.