docker dev and prod template #4936
Merged
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added VESPA_LANGUAGE_OVERRIDE configuration to Docker environments for controlling Vespa's linguistic processing behavior in multilingual deployments.
- Added
VESPA_LANGUAGE_OVERRIDEoption todeployment/docker_compose/env.prod.templatewith documentation referencing Vespa's official docs - Added corresponding environment variable to API server configuration in
deployment/docker_compose/docker-compose.dev.ymlfor development environments - This change enables forcing specific language handling in Vespa across both production and development deployments
- Configuration follows existing patterns for optional settings by being commented out by default in templates
2 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
Comment on lines
+65
to
+67
| # If setting the vespa language is required, set this ('en', 'de', etc.). | ||
| # See: https://docs.vespa.ai/en/linguistics.html | ||
| #VESPA_LANGUAGE_OVERRIDE= |
There was a problem hiding this comment.
style: Add example values in the comment to make it clearer. E.g.: '#VESPA_LANGUAGE_OVERRIDE=en # Supported values: en, de, es, fr, etc.'
Suggested change
| # If setting the vespa language is required, set this ('en', 'de', etc.). | |
| # See: https://docs.vespa.ai/en/linguistics.html | |
| #VESPA_LANGUAGE_OVERRIDE= | |
| # If setting the vespa language is required, set this ('en', 'de', etc.). | |
| # See: https://docs.vespa.ai/en/linguistics.html | |
| #VESPA_LANGUAGE_OVERRIDE=en # Supported values: en, de, es, fr, etc. |
Comment on lines
+133
to
+135
| # Vespa Language Forcing | ||
| # See: https://docs.vespa.ai/en/linguistics.html | ||
| - VESPA_LANGUAGE_OVERRIDE=${VESPA_LANGUAGE_OVERRIDE:-} |
There was a problem hiding this comment.
style: consider adding this env var to the background service too since it also interacts with Vespa for indexing operations
Weves
approved these changes
Jun 23, 2025
Weves
pushed a commit
that referenced
this pull request
Jun 27, 2025
* docker dev and prod template * more dev files
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* docker dev and prod template * more dev files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding Vespa language overwrite to docker files
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.