fix: Fix sidebar logic to hit kg-endpoint for admins only #4938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
raunakab
force-pushed
the
fix/kg-exposed-hang
branch
from
c429b43 to
b12ddf6
Compare
raunakab
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Optimizes Knowledge Graph exposure status checks by removing excessive API polling behavior in the admin interface.
- Added
web/src/app/admin/kg/utils.tsintroducinguseIsKGExposedhook with disabled SWR auto-revalidation flags to prevent continuous refreshing - Modified
web/src/components/admin/ClientLayout.tsxto use the new hook and tightened KG exposed type fromboolean | nulltoboolean - Follows principle of 'fail loudly' by enforcing admin-only access and providing explicit boolean typing
- Implements better resource management by removing unnecessary repeated API calls
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
Weves
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the constant refresh of the KG-exposed endpoint.
Addresses: https://linear.app/danswer/issue/DAN-2114/fix-fetching-of-kg-exposed-endpoint.
How Has This Been Tested?
Not tested.