KG vespa error handling + separating relationship transfer & vespa updates #4954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Improved knowledge graph clustering by decoupling relationship transfers from Vespa updates, enhancing error handling and observability in backend/onyx/kg/clustering/clustering.py.
- Split monolithic
_transfer_batch_relationship_and_update_vespainto separate operations, improving maintainability and failure isolation - Added detailed error handling for Vespa updates with per-document failure logging
- Introduced
_get_batch_kg_processed_documentsfor better document batch processing - Added performance metrics and timing logs for each major operation stage
- Improved resilience by ensuring Vespa update failures don't block other document processing
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
joachim-danswer
approved these changes
Jun 27, 2025
Orbital-Web
force-pushed
the
kg-vespa-improvements
branch
from
3dd7d50 to
1862ca5
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
…dates (onyx-dot-app#4954) * feat: move vespa at end in try block * simplify query * mypy * added order by just in case for consistent pagination * liveness probe * kg_p check for both extraction and clustering * fix: better vespa logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separated relationship transferring and vespa updates
Proper error handling on vespa updates
How Has This Been Tested?
Locally
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.