kg source fix #4956
Merged
kg source fix #4956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Optimized knowledge graph batch metadata querying by reducing unnecessary database joins and adding source filtering. This change makes document processing (number of docs)/(number of connectors) times faster.
- Added
connector_sourceparameter to_get_batch_documents_enhanced_metadatato filter results upfront - Removed redundant database joins per document for determining source type in
get_batch_documents_metadata - Fixed issue with multiple rows being returned in batch metadata queries
- Performance improvement achieved by passing source type directly instead of querying it repeatedly
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
joachim-danswer
approved these changes
Jun 27, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed multiple row returned in get batch metadata, and made the query (number of docs) / (number of connectors) times faster (just the querying 😃 ).
How Has This Been Tested?
Locally
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.