feat: Implement indexed file saving to populate url and remove b64 da… #4963
Conversation
…ta before saving it to db
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Optimizes image handling in chat responses by replacing base64 data storage with URL references to saved files.
- Introduces
IndexedDataandIndexedResultinfile_store/utils.pyto maintain order while saving multiple files concurrently - Adds
cleaned_image_responsesfield toAnswerPostInfomodel for storing optimized image URLs - Centralizes tool name constants in new
constants.pyfile for better maintainability - Modifies
image_generation_tool.pyto support both URL and base64 formats based on configuration - Implements helper functions in
process_message.pyfor separate handling of URL and base64 content
7 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
| # Store cleaned image responses with URLs for later tool_result cleaning | ||
| cleaned_image_responses: list[Any] | None = None |
There was a problem hiding this comment.
style: This field should use a more specific type than 'Any' to ensure type safety. Consider creating a dedicated type/class for image responses or at minimum use a type like 'list[dict[str, str]]' to better document the expected structure.
| # Combine all tasks with their indices | ||
| funcs: list[ | ||
| tuple[ | ||
| Callable[[IndexedData | None, IndexedData | None], IndexedResult], | ||
| tuple[IndexedData | None, IndexedData | None], | ||
| ] | ||
| ] = [(save_file_indexed, (indexed_url, None)) for indexed_url in indexed_urls] + [ | ||
| (save_file_indexed, (None, indexed_base64)) | ||
| for indexed_base64 in indexed_base64_files | ||
| ] |
There was a problem hiding this comment.
style: Type hints for funcs could be simplified with type alias to improve readability
|
This PR is stale because it has been open 75 days with no activity. Remove stale label or comment or this will be closed in 15 days. |
|
This PR was closed because it has been stalled for 90 days with no activity. |
Description
Replacing base64 data with the URL of the newly created file in the image tool result.
How Has This Been Tested?
From UI and confirmed in the DB.
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.