Skip to content

Conversation

Weves
Copy link
Contributor

@Weves Weves commented Jun 28, 2025

Description

Seems to be causing all sorts of deadlocks and weirdness on cloud + not needed anymore since all large deployments have run this migration already.

How Has This Been Tested?

Ran migrations locally.

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

@Weves Weves requested a review from a team as a code owner June 28, 2025 18:59
Copy link

vercel bot commented Jun 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 28, 2025 6:59pm

@Weves Weves merged commit 106c685 into main Jun 28, 2025
11 of 14 checks passed
@Weves Weves deleted the remove-concurrently branch June 28, 2025 19:00
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR removes the CONCURRENTLY keyword from index creation/deletion operations in migration scripts, with significant potential risks for new deployments.

  • Migration 3bd4c84fe72f (dated 2025-02-26) has its CONCURRENTLY operations removed, which could cause table-locking and downtime for future deployments that haven't run these migrations
  • The COMMIT statements critical for transaction management have been removed, which could lead to deadlocks in Postgres
  • Removal of CONCURRENTLY from GIN index operations in 495cb26ce93e is particularly concerning as GIN indexes are typically resource-intensive to build
  • The PR's justification that "all large deployments have run this migration" doesn't account for new deployments, test environments, or future database rebuilds

2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant