Remove hardcoded image extraction flag for PDFs #4970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PDFs currently always have their images extracted. This will make use of the "Enable Image Extraction and Analysis" workspace configuration instead.
|
@emerzon is attempting to deploy a commit to the Danswer Team on Vercel. A member of the Team first needs to authorize it. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Improves PDF processing configuration by removing hardcoded image extraction flag, now respecting the workspace's 'Enable Image Extraction and Analysis' setting.
- Modified
backend/onyx/file_processing/extract_file_text.pyto use dynamic configuration instead of forcingextract_images=Truefor PDFs - Ensures consistent image extraction behavior across document types based on workspace settings
- Provides better resource utilization by only extracting images when explicitly enabled
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
Weves
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PDFs currently always have their images extracted. This will make use of the "Enable Image Extraction and Analysis" workspace configuration instead.