Skip to content

Remove hardcoded image extraction flag for PDFs #4970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025
Merged

Remove hardcoded image extraction flag for PDFs #4970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion backend/onyx/file_processing/extract_file_text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@

from onyx.configs.constants import FileOrigin
from onyx.configs.constants import ONYX_METADATA_FILENAME
from onyx.configs.llm_configs import get_image_extraction_and_analysis_enabled
from onyx.file_processing.html_utils import parse_html_page_basic
from onyx.file_processing.unstructured import get_unstructured_api_key
from onyx.file_processing.unstructured import unstructured_to_text
Expand Down Expand Up @@ -533,7 +534,7 @@ def extract_text_and_images(
if extension == ".pdf":
file.seek(0)
text_content, pdf_metadata, images = read_pdf_file(
file, pdf_pass, extract_images=True
file, pdf_pass, extract_images=get_image_extraction_and_analysis_enabled()
)
return ExtractionResult(
text_content=text_content, embedded_images=images, metadata=pdf_metadata
Expand Down
Loading