search speedup #4971
Merged
search speedup #4971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Restores critical search optimization parameters in backend/onyx/tools/tool_implementations/search/search_tool.py that were accidentally removed, preventing redundant computations during search.
- Re-added
precomputed_is_keyword,precomputed_keywords, andprecomputed_query_embeddingparameters to preserve pre-computed values during search operations - These parameters prevent expensive re-computation of keyword analysis and embeddings that were previously calculated
- Improvement aligns with codebase's emphasis on search performance optimization as seen in
preprocessing.py
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
Weves
approved these changes
Jun 30, 2025
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
My Documents deleted some code that was critically important for search performance, this adds it back
How Has This Been Tested?
tested in UI
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.