drive service account shared fixes #4977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Fixes Google Drive service account indexing to properly include files shared with specific users. The changes remove special UI handling and align backend behavior.
- Hardcoded debugging code in
backend/onyx/connectors/google_utils/google_utils.pyneeds to be removed before merging (document ID '1G0rnd9CdK8LTRc-V02U7uTWfuJjv_9f961LvbtHTTwg' and print statements) - Removes
currentCredentialparameter fromcreateConnectorInitialValuesinweb/src/app/admin/connectors/[connector]/AddConnectorPage.tsxfor better separation of concerns - Sets
include_files_shared_with_meto defaultfalsein UI like other checkboxes instead of forcingtruefor service accounts - Added test case
test_specific_user_email_shared_with_meto verify service account indexing behavior - Modified backend to correctly handle shared files when using service account authentication
5 files reviewed, 4 comments
Edit PR Review Bot Settings | Greptile
backend/tests/daily/connectors/google_drive/test_service_acct.py
Outdated
Show resolved
Hide resolved
backend/tests/daily/connectors/google_drive/test_service_acct.py
Outdated
Show resolved
Hide resolved
evan-onyx
force-pushed
the
bugfix/drive-missing-docs
branch
from
aacd9db to
89cfb76
Compare
Weves
reviewed
Jul 2, 2025
web/src/app/admin/connector/[ccPairId]/IndexAttemptErrorsModal.tsx
Outdated
Show resolved
Hide resolved
Weves
approved these changes
Jul 2, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* drive service account shared fixes * oops * ily greptile * scrollable index attempt errors * tentatively correct index errors page, needs testing * mypy * black * better bounds in practice * remove random failures * remove console log * CW
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses https://linear.app/danswer/issue/DAN-2157/fix-drive-shared-with-me-for-specific-user
service account indexing was not properly including files shared with the user when indexing as a specific user
How Has This Been Tested?
tested in UI + unit test
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.