Skip to content

Conversation

Orbital-Web
Copy link
Contributor

@Orbital-Web Orbital-Web commented Jul 2, 2025

Description

Fixed annoying TestDBBase error when running mypy locally due to mypy bug + another mypy issue

Note the mypy issue happens for some people and not others. It also seems to be affected by the number of times you run mypy (first time works, 2+ times causes issues). Weird.

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

@Orbital-Web Orbital-Web requested a review from a team as a code owner July 2, 2025 01:19
Copy link

vercel bot commented Jul 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2025 1:22am

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Addresses mypy type checking issues in test files and improves code formatting for better readability.

  • Added # type: ignore annotation to FileRecord test class in backend/tests/unit/file_store/test_file_store.py to resolve mypy type checking error
  • Improved readability in backend/onyx/file_processing/extract_file_text.py by reformatting read_pdf_file function call into multiple lines
  • Fixes TestDBBase mypy error when running type checks locally

2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile

@Weves Weves merged commit 5e14f23 into main Jul 2, 2025
14 of 16 checks passed
@Weves Weves deleted the mypy-fix branch July 2, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants