Fix broken Drag&Drop file upload #4981
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t upload API; Add a spinning loader for when file upload is ongoing
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Unifies file upload mechanisms in the chat interface by consolidating upload endpoints and improving UX feedback during uploads.
- Consolidated upload endpoints to exclusively use
/api/chat/fileinstead of mixing with/api/user/file/uploadinweb/src/app/chat/ChatPage.tsx - Added blocking spinner UI feedback during file uploads to prevent premature user interactions in
web/src/app/chat/input/ChatInputBar.tsx - Implemented unified file handling by combining selected and current message files into a single array for consistent processing
- Improved error handling with specific error messages for upload failures
- Removed redundant
uploadFileprop fromuseDocumentsContextto streamline the upload flow
2 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
|
@emerzon is attempting to deploy a commit to the Danswer Team on Vercel. A member of the Team first needs to authorize it. |
…/undefined IDs are now filtered out before creating file descriptors
|
This PR is stale because it has been open 75 days with no activity. Remove stale label or comment or this will be closed in 15 days. |
|
This PR was closed because it has been stalled for 90 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/api/user/file/uploadand/api/chat/file, unifying uploads mechanism to use Chat API.How Has This Been Tested?
+ Filefeature)