add docx fallback #4983
Merged
add docx fallback #4983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added a fallback mechanism to docx file processing that attempts to read files as plain text when DOCX parsing fails, improving handling of corrupted or mislabeled files.
- Implemented fallback text extraction in
backend/onyx/file_processing/extract_file_text.pywhen DOCX parsing fails - Change aligns with fail-loudly principle but provides graceful degradation for potentially recoverable content
- Security consideration: Added handling of untrusted files that could be maliciously mislabeled as DOCX
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Comment on lines
312
to
+325
| try: | ||
| doc = docx.Document(file) | ||
| except BadZipFile as e: | ||
| logger.warning(f"Failed to extract text from {file_name or 'docx file'}: {e}") | ||
| return "", [] | ||
| logger.warning( | ||
| f"Failed to extract docx {file_name or 'docx file'}: {e}. Attempting to read as text file." | ||
| ) | ||
|
|
||
| # May be an invalid docx, but still a valid text file | ||
| file.seek(0) | ||
| encoding = detect_encoding(file) | ||
| text_content_raw, _ = read_text_file( | ||
| file, encoding=encoding, ignore_onyx_metadata=False | ||
| ) | ||
| return text_content_raw or "", [] |
There was a problem hiding this comment.
logic: Verify file type before fallback. An invalid docx file could be malicious - should validate it's actually a text file using is_text_file() before attempting to read it.
Weves
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Provide a brief description of the changes in this PR]
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.