check file size first and clarify processing logic #4985
Merged
+54
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Optimized Google Drive file processing by reordering validation checks for better efficiency.
- Moved file size validation to run before any content processing attempts in
backend/onyx/connectors/google_drive/doc_conversion.pyto avoid unnecessary processing of files that would be rejected - Restructured processing flow to: check size limits → process Google Docs → handle non-Google Doc files
- Improves resource efficiency by failing fast on size-invalid files before attempting expensive document parsing
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
evan-onyx
approved these changes
Jul 3, 2025
added 2 commits
July 3, 2025 14:05
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* check file size first and clarify processing logic * basic gdrive extraction clariy * typo --------- Co-authored-by: Wenxi Onyx <wenxi-onyx@Wenxis-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Original: process google docs --> check and invalidate file size --> process non google docs
Fix: check and invalidate file size --> process docs --> process non docs
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.