fix: Fix bug with incorrect model icon being shown #4986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Refactored LLM model selection UI to fix incorrect model icon display through improved component architecture and type safety.
- Moved trigger button from
web/src/app/chat/input/ChatInputBar.tsxintoLLMPopovercomponent for better encapsulation - Simplified LLM options from nested provider structure to flat list in
web/src/app/chat/input/LLMPopover.tsx - Removed problematic hardcoded fallback values (anthropic/claude) that could cause icon mismatches
- Added provider parameter to
modelSupportsImageInputfor more accurate capability detection - Improved type safety by properly using
LlmDescriptortype instead of string parsing
2 files reviewed, 4 comments
Edit PR Review Bot Settings | Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Weves
approved these changes
Jul 4, 2025
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* Fix bug with incorrect model icon being shown * Update web/src/app/chat/input/LLMPopover.tsx Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Update web/src/app/chat/input/LLMPopover.tsx Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Update web/src/app/chat/input/LLMPopover.tsx Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Update web/src/app/chat/input/LLMPopover.tsx Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Add visibility to filtering * Update the model names which are shown in the popup * Fix incorrect llm updating bug * Fix bug in which the provider name would be used instead --------- Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the issue in which the incorrect model icon was being shown.
Addresses: https://linear.app/danswer/issue/DAN-2159/fix-incorrect-model-icon-being-shown.
How Has This Been Tested?
UI changes; no testing needed.