feat: IMAP connector #4987
Merged
feat: IMAP connector #4987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
New IMAP connector implementation for email integration shows significant gaps and missing core functionality that need to be addressed before it can be production-ready.
- Connector in
backend/onyx/connectors/imap/connector.pylacks critical time range filtering despite accepting start/end parameters, which is essential for the Poll/Load connector interfaces - Core email processing functionality in
backend/onyx/connectors/imap/__init__.pyis incomplete with NotImplementedError stubs and commented-out code for email body processing - Email header extraction in
backend/onyx/connectors/imap/models.pyneeds more robust error handling for missing content_type fields and mismatched field validations - Security improvements needed in credential handling implementation, particularly around SSL configuration and token storage
- Limited email folder support (only 'Inbox' currently) requires expansion for full IMAP capabilities
4 files reviewed, 9 comments
Edit PR Review Bot Settings | Greptile
- possible in mailing-list workflows
…ished / how login is done
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* Implement fetching; still need to work on document parsing * Add basic skeleton of parsing email bodies * Add id field * Add email body parsing * Implement checkpointed imap-connector * Add testing logic for basic iteration * Add logic to get different header if "to" isn't present - possible in mailing-list workflows * Add ability to index specific mailboxes * Add breaking when indexing has been fully exhausted * Sanitize all mailbox names + add space between stripped strings after parsing * Add multi-recipient parsing * Change around semantic-identifier and title * Add imap tests * Add recipients and content assertions to tests * Add envvars to github actions workflow file * Remove encoding header * Update logic to not immediately establish connection upon init of `ImapConnector` * Add start and end datetime filtering + edit when connection is established / how login is done * Remove content-type header * Add note about guards * Change default parameters to be `None` instead of `[]` * Address comment on PR * Implement more PR suggestions * More PR suggestions * Implement more PR suggestions * Change up login/logout flow (PR suggestion) * Move port number to be envvar * Make globals variants in enum instead (PR suggestion) * Fix more documentation related suggestions on PR * Have the imap connector implement `CheckpointedConnectorWithPermSync` instead * Add helper for loading all docs with permission syncing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for a generic email connector.
Addresses: https://linear.app/danswer/issue/DAN-2160/add-a-new-imap-connector.
How Has This Been Tested?
Unit + integration tests TODO.