Skip to content

Conversation

emerzon
Copy link
Contributor

@emerzon emerzon commented Jul 4, 2025

Description

.epub files apparently were forgotten and were not allowed for upload in the frontend, even though the backend can process them.

How Has This Been Tested?

Upload a .epub file

.epub files apparently were forgotten and were not allowed for upload in the frontend.
@emerzon emerzon requested a review from a team as a code owner July 4, 2025 01:15
Copy link

vercel bot commented Jul 4, 2025

@emerzon is attempting to deploy a commit to the Danswer Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added .epub file upload support in the frontend by including it in the ALLOWED_FILE_TYPES array, aligning with existing backend processing capabilities.

  • Added .epub to web/src/app/chat/my-documents/[id]/UserFolderContent.tsx ALLOWED_FILE_TYPES array, maintaining alphabetical order in the Documents section
  • Simple frontend validation change that unlocks existing backend functionality
  • Change is non-breaking since backend already supports .epub processing

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

@Orbital-Web
Copy link
Contributor

seems good, thanks for the catch!

@Orbital-Web Orbital-Web enabled auto-merge July 5, 2025 14:48
@Orbital-Web Orbital-Web disabled auto-merge July 5, 2025 14:48
@Orbital-Web Orbital-Web merged commit cd63bf6 into onyx-dot-app:main Jul 5, 2025
6 of 12 checks passed
AnkitTukatek pushed a commit to TukaTek/onyx that referenced this pull request Sep 23, 2025
.epub files apparently were forgotten and were not allowed for upload in the frontend.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants