Bugfix/drive doc ids #4990
Merged
Bugfix/drive doc ids #4990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Fixes duplicate document issues in Google Drive integration by normalizing document IDs across the system, with supporting database migrations and UI improvements.
- New migration
backend/alembic/versions/12635f6655b7_drive_canonical_ids.pyimplements document ID normalization by removing URL parameters and standardizing paths - Modified
backend/onyx/connectors/google_drive/doc_conversion.pyto clean up Google Drive URLs by removing '/edit', '/view', and query parameters - Enhanced
web/src/app/admin/connector/[ccPairId]/IndexAttemptErrorsModal.tsxwith improved scrollable error messages and consistent table layouts - Added defensive 'DROP TABLE IF EXISTS CASCADE' statements in multiple migration files for safer schema updates
7 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Comment on lines
+533
to
+534
| print(f"Failed to update document {current_doc_id}: {e}") | ||
| from httpx import HTTPStatusError |
There was a problem hiding this comment.
style: HTTPStatusError import should be at top of file with other imports
Suggested change
| print(f"Failed to update document {current_doc_id}: {e}") | |
| from httpx import HTTPStatusError | |
| print(f"Failed to update document {current_doc_id}: {e}") |
Weves
approved these changes
Jul 4, 2025
Comment on lines
+533
to
+534
| print(f"Failed to update document {current_doc_id}: {e}") | ||
| from httpx import HTTPStatusError |
evan-onyx
force-pushed
the
bugfix/drive-doc-ids
branch
from
2509bd1 to
90aae5f
Compare
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* fixed id extraction in drive connector * WIP migration * full migration script * migration works single tenant without duplicates * tested single tenant with duplicate docs * migrations and frontend * tested mutlitenant * fix connector tests * make tests pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-2162/drive-doc-deduplication
dupe drive ids fixed
How Has This Been Tested?
tested in ui + multitenant
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.