fireflies metadata update #4993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced Fireflies connector to better expose meeting metadata by explicitly adding meeting date and duration to Document metadata, improving context for AI interactions.
- Modified GraphQL query in
backend/onyx/connectors/fireflies/connector.pyto fetch duration field from Fireflies API - Added metadata dictionary to Document constructor with meeting_date and duration_min fields for clearer data representation
- Potential issue: Missing type validation for duration field before integer conversion, could cause runtime errors if API returns invalid data
- Missing error handling for cases where duration field is missing or null in API response
- Consider adding input validation to ensure duration is within reasonable bounds (e.g., not negative or unreasonably large)
3 files reviewed, 3 comments
Edit PR Review Bot Settings | Greptile
| target_doc.source == DocumentSource.FIREFLIES | ||
| ), "Document source is not fireflies" | ||
| assert target_doc.metadata == {} | ||
| assert target_doc.metadata == test_data["metadata"] |
There was a problem hiding this comment.
style: Consider adding explicit assertions for the expected metadata fields (date and duration) rather than just comparing the whole dict
Weves
approved these changes
Jul 5, 2025
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* fireflies metadata * str
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added date + duration
Date is part of the context string (doc_updated_at) already, but it seems like the model doesn't make the connection that updated_at = time of the meeting. Also, duration is the length of the meeting in minutes, floored to the nearest integer. Even if the last half of the meeting is silent, it will still count towards the duration. I think this is fine in most cases though.
How Has This Been Tested?
Before:
After:
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.