feat: Add support for Confluence Macros #5001
Merged
+21
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added functionality to clean up Confluence macro stylings in backend/onyx/connectors/confluence/onyx_confluence.py, improving document parsing cleanliness.
- Added new
_remove_macro_stylingsfunction to strip unnecessary style parameters from Confluence HTML content - Removed legacy commented-out code (
_wrap_methodsand_ensure_token_valid) for better code cleanliness - Specifically targets
ac:parameterelements withac:name="page"attributes for removal
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* Remove macro stylings from HTML tree * Add params * Handle multiple cases of `ac:structured-macro` being found. Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> --------- Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables support for parsing Confluence Macros and removing the unnecessary styling.
Addresses: https://linear.app/danswer/issue/DAN-2164/add-support-for-confluence-karma-parsing.
How Has This Been Tested?
Manually tested.