Stop fetching channel info to make pages load faster #5005
Merged
+6
−185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Performance optimization for Slack bot configuration by removing channel fetch functionality. This significantly improves page load times by:
- Removed
/admin/slack-app/bots/{bot_id}/channelsendpoint inbackend/onyx/server/manage/slack_bot.pythat was causing multi-second delays - Replaced Slack channel dropdown with direct text input in
web/src/app/admin/bots/[bot-id]/channels/SlackChannelConfigFormFields.tsxto avoid loading incomplete channel lists - Eliminated
fetchSlackChannelsfunction fromweb/src/app/admin/bots/[bot-id]/lib.ts, removing a network-heavy operation - Improved UX by preventing misleading partial channel lists that only showed first 500 channels
3 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
raunakab
approved these changes
Jul 9, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-2165/stop-fetching-channel-info-to-make-pages-load-faster
Previously took a few seconds to load the page + it only loaded a small subset of channels, which made it misleading.
How Has This Been Tested?
Set up slack bot locally.
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.