skip id migration based on env var #5007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added environment variable bypass for Google Drive canonical ID migration due to performance issues with the current implementation.
- Modified
backend/alembic/versions/12635f6655b7_drive_canonical_ids.pyto introduceSKIP_CANON_DRIVE_IDSenvironment variable that bypasses the migration - Warning: Skipping migration will result in duplicate Drive documents being indexed until migration is eventually completed
- Consider adding metrics/logging to understand the root cause of migration performance issues for future resolution
- Ensure clear documentation/tracking exists to remind team that this migration needs to be completed eventually
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Comment on lines
519
to
+521
| def upgrade() -> None: | ||
| if SKIP_CANON_DRIVE_IDS: | ||
| return |
There was a problem hiding this comment.
style: Consider adding a warning log when skipping migration to help with debugging and monitoring
Weves
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the migration takes forever for currently unknown reasons, skipping it for the time being. Downside is until it is run, everyone will see duplicate drive docs being indexed
How Has This Been Tested?
n/a
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.