feat: Add frontend for email connector #5008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
raunakab
commented
Jul 10, 2025
- imaplib.IMAP4_SSL is supposed to be treated as an ephemeral object
raunakab
commented
Jul 10, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR implements the frontend configuration flow for the IMAP email connector, enabling email integration as a new Personal category data source.
- Error handling in
backend/onyx/connectors/imap/connector.pyneeds improvement: missing proper IMAP connection cleanup, using print statements instead of logger, and incorrect type checking for 'name' vs 'value' - Memory optimization needed for HTML email parsing with BeautifulSoup in the connector implementation to handle large emails
- 'TODO!' testing section needs to be completed before merging, particularly for frontend connector configuration flows
- The email connector is placed in the Personal category unlike other messaging connectors (Gmail, Slack) which are in Messaging - consider if this categorization makes sense
- IMAP connector is not included in validAutoSyncSources, suggesting future work needed for auto-sync support
13 files reviewed, 4 comments
Edit PR Review Bot Settings | Greptile
web/src/app/admin/connectors/[connector]/pages/DynamicConnectorCreationForm.tsx
Show resolved
Hide resolved
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* Add basic structure for frontend email connector * Update names of credentials-json keys * Fix up configurations workflow * Edit logic on how `mail_client` is used - imaplib.IMAP4_SSL is supposed to be treated as an ephemeral object * Edit helper name and add docs * Fix invalid mailbox selection error * Implement greptile suggestions * Make recipients optional and add sender to primary-owners * Add sender to external-access too; perform dedupe-ing of emails * Simplify logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables a frontend configuration flow for the new email connector.
Addresses: https://linear.app/danswer/issue/DAN-2167/add-imap-frontend.
How Has This Been Tested?
Mainly UI change; existing IMAP connector tests still passing.