Send over less data for document sets #5018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR optimizes data transfer by introducing streamlined summary models (DocumentSetSummary, CCPairSummary, FederatedConnectorSummary) that reduce payload size when fetching document sets.
- Added new
DocumentSetSummaryPydantic model inbackend/onyx/server/features/document_set/models.pythat provides a lightweight alternative to the full DocumentSet - Changed
list_document_sets_for_userendpoint inbackend/onyx/server/features/document_set/api.pyto return summary models instead of full data - Updated frontend components in
web/src/app/admin/documents/sets/to use new summary types while maintaining existing functionality - Ensured backward compatibility in
SlackChannelConfigFormFieldsby handling both old and new data structures - Removed verbose metadata from connector displays while preserving essential fields (id, name, source, access_type)
10 files reviewed, 3 comments
Edit PR Review Bot Settings | Greptile
web/src/app/admin/bots/[bot-id]/channels/SlackChannelConfigFormFields.tsx
Outdated
Show resolved
Hide resolved
raunakab
approved these changes
Jul 13, 2025
Weves
added a commit
that referenced
this pull request
Jul 15, 2025
* Send over less data for document sets * Fix type errors * Fix tests * Fixes * Don't change packages
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* Send over less data for document sets * Fix type errors * Fix tests * Fixes * Don't change packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-2174/send-over-less-data-in-managedocument-set
How Has This Been Tested?
Verified normal behavior locally.
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.