-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: Fix failing IMAP tests #5025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- imaplib.IMAP4_SSL is supposed to be treated as an ephemeral object
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This PR fixes failing IMAP connector tests by updating test data to match the actual email recipient lists. Specifically, 'raunak@onyx.app' has been added as an additional recipient in two test email documents. This is a test-only change that aligns the test expectations with the actual email data being tested against, rather than a change in functionality.
This change fits into the codebase's connector testing framework, which is part of the automated testing pipeline that runs daily via GitHub Actions (as seen in pr-python-connector-tests.yml). IMAP tests are one of many connector tests that verify email integration functionality.
Confidence score: 5/5
- This PR is very safe to merge as it only modifies test data, not production code
- High confidence score given because the change is minimal, well-scoped, and only affects test assertions
- Files needing attention: None - the changes are straightforward and only affect test data
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
Description
Fix failing IMAP tests. No linear ticket assigned to this PR.
How Has This Been Tested?
Tests are now passing.