Persona simplification r2 #5031

Weves · 2025-07-15T21:03:26Z

Description

^

How Has This Been Tested?

Tested locally

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

This PR should be backported (make sure to check that the backport attempt succeeds)
[Optional] Override Linear Check

Summary by cubic

Simplified the persona API and frontend data model to only fetch and use minimal persona data on /persona, reducing payload size and improving performance.

Refactors
- Added MinimalPersonaSnapshot for lightweight persona data.
- Updated backend endpoints and frontend components to use minimal persona data where possible.
- Removed unused fields from persona fetches and refactored related hooks, context, and utilities.

#5024)" This reverts commit f7ed7cd.

vercel · 2025-07-15T21:03:30Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
internal-search	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 15, 2025 9:42pm

greptile-apps

Greptile Summary

This PR implements a significant architectural change to simplify the persona system across the application. The key changes include:

Introduction of a MinimalPersonaSnapshot type that contains only essential fields needed for basic persona functionality
Widespread replacement of full Persona type with MinimalPersonaSnapshot across frontend components
Refactoring of database queries and API endpoints to support efficient loading of minimal persona data
Removal of unnecessary complexity around file/folder ID checks for retrieval capabilities
Improved type safety and code organization through better interface segregation

The changes aim to optimize data transfer between frontend and backend by ensuring components only receive the data they actually need, potentially improving performance and reducing unnecessary prop drilling.

Confidence score: 4 /5

This PR is safe to merge with proper testing as it's primarily a type-level change with careful interface design
High score due to consistent implementation across many files and clear architectural benefits, slightly reduced due to lack of testing details in PR description
Key files needing attention:
- backend/onyx/server/features/persona/models.py - New MinimalPersonaSnapshot implementation
- web/src/app/admin/assistants/interfaces.ts - Core type definitions
- web/src/app/chat/ChatPage.tsx - Critical component using new types

_{50 files reviewed, 6 comments}
_{Edit PR Review Bot Settings | Greptile}

web/src/app/admin/assistants/hooks.ts

backend/onyx/server/features/document_set/models.py

web/src/lib/assistants/fetchAssistantsSS.ts

web/src/app/admin/assistants/page.tsx

web/src/components/context/AssistantsContext.tsx

backend/onyx/server/openai_assistants_api/asssistants_api.py

cubic-dev-ai

cubic found 26 issues across 50 files. Review them in cubic.dev

_{React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.}

cubic-dev-ai · 2025-07-15T21:06:48Z

backend/onyx/server/features/document_set/api.py

        db_session=db_session, user=user, get_editable=get_editable
    )
-    return [DocumentSetSummary.from_document_set(ds) for ds in document_sets]
+    return [DocumentSetSummary.from_model(ds) for ds in document_sets]


Rule violated: Prefer long, explicit variable names

Variable name "ds" is an overly abbreviated identifier and violates the explicit naming rule; use a descriptive name with at least 3 words and 12 characters.

Suggested change

return [DocumentSetSummary.from_model(ds) for ds in document_sets]

return [DocumentSetSummary.from_model(document_set) for document_set in document_sets]

cubic-dev-ai · 2025-07-15T21:06:48Z

web/src/app/admin/bots/[bot-id]/channels/SlackChannelConfigFormFields.tsx

-                    </button>
-                  ))}
+                  {syncEnabledAssistants.map(
+                    (persona: MinimalPersonaSnapshot) => (


Rule violated: Prefer long, explicit variable names

Function parameter name "persona" does not meet the minimum 3-word, 12-character requirement specified by the naming rule.

cubic-dev-ai · 2025-07-15T21:06:48Z

web/src/app/admin/bots/[bot-id]/channels/SlackChannelConfigFormFields.tsx

-    const sync: Persona[] = [];
-    const available: Persona[] = [];
+    const sync: MinimalPersonaSnapshot[] = [];
+    const available: MinimalPersonaSnapshot[] = [];


Rule violated: Prefer long, explicit variable names

Variable name "available" is not descriptive enough; it must have at least 3 words and 12 characters according to the naming rule.

cubic-dev-ai · 2025-07-15T21:06:48Z

web/src/app/admin/bots/[bot-id]/channels/SlackChannelConfigFormFields.tsx

  const [syncEnabledAssistants, availableAssistants] = useMemo(() => {
-    const sync: Persona[] = [];
-    const available: Persona[] = [];
+    const sync: MinimalPersonaSnapshot[] = [];


Rule violated: Prefer long, explicit variable names

Variable name "sync" is overly abbreviated and violates the naming rule requiring at least 3 words and 12 characters for clarity.

cubic-dev-ai · 2025-07-15T21:06:48Z

web/src/app/admin/assistants/hooks.ts

+export const useAdminPersonas = (options?: UseAdminPersonasOptions) => {
+  const { includeDeleted = false, getEditable = false } = options || {};
+
+  const url = buildApiPath("/api/admin/persona", {


Rule violated: Prefer long, explicit variable names

Multiple newly introduced variable names (options, includeDeleted, getEditable, url, data, error, isLoading, mutate) are shorter than 3 words and/or fewer than 12 characters, violating the "Prefer long, explicit variable names" guideline.

cubic-dev-ai · 2025-07-15T21:06:50Z

backend/onyx/server/openai_assistants_api/asssistants_api.py

 ) -> ListAssistantsResponse:
-    personas = list(
-        get_personas_for_user(
+    persona_snapshots = list(


Rule violated: Everything Python should be as strictly typed as possible

Variable 'persona_snapshots' is assigned a non-literal value without an explicit type annotation, violating the strict typing rule.

Suggested change

persona_snapshots = list(

persona_snapshots: list[Persona] = list(

cubic-dev-ai · 2025-07-15T21:06:51Z

backend/onyx/server/openai_assistants_api/asssistants_api.py

        first_id=assistants[0].id if assistants else None,
        last_id=assistants[-1].id if assistants else None,
-        has_more=len(personas) == limit,
+        has_more=len(persona_snapshots) == limit,


has_more is calculated after the list was sliced to limit, so it returns true whenever exactly limit items are returned, even when no additional records exist, providing inaccurate pagination information.

cubic-dev-ai · 2025-07-15T21:06:51Z

backend/onyx/server/openai_assistants_api/asssistants_api.py

-    personas = list(
-        get_personas_for_user(
+    persona_snapshots = list(
+        get_raw_personas_for_user(


get_raw_personas_for_user does not eager-load related tables; persona_to_assistant later accesses persona.tools and persona.prompts, so each access triggers separate queries, causing an N+1 performance issue.

cubic-dev-ai · 2025-07-15T21:06:51Z

web/src/app/admin/assistants/hooks.ts

+    get_editable: getEditable.toString(),
+  });
+
+  const { data, error, isLoading, mutate } = useSWR<Persona[]>(


Rule violated: Prefer pure stateless functions

Calling useSWR here triggers an HTTP request (via errorHandlingFetcher), making useAdminPersonas an impure function in direct conflict with the "Prefer pure stateless functions" rule which prohibits I/O operations inside function bodies.

cubic-dev-ai · 2025-07-15T21:06:51Z

backend/onyx/db/persona.py

+        selectinload(Persona.document_sets),
+        selectinload(Persona.user),
+    )
+    results = db_session.scalars(stmt).all()


Rule violated: Prefer pure stateless functions

Performs a database query inside the function, introducing I/O and external state dependency, in direct violation of the "Prefer pure stateless functions" rule.

* Revert "Revert "Reduce amount of stuff we fetch on `/persona` (#4988)" (#5024)" This reverts commit f7ed7cd. * Enhancements / fix re-render * re-arrange * greptile

* Revert "Revert "Reduce amount of stuff we fetch on `/persona` (onyx-dot-app#4988)" (onyx-dot-app#5024)" This reverts commit 457e43d. * Enhancements / fix re-render * re-arrange * greptile

Weves added 3 commits July 15, 2025 12:26

Revert "Revert "Reduce amount of stuff we fetch on /persona (#4988)" (

6604e1f

#5024)" This reverts commit f7ed7cd.

Enhancements / fix re-render

1af91cd

re-arrange

074dfa8

Weves requested a review from a team as a code owner July 15, 2025 21:03

greptile-apps bot reviewed Jul 15, 2025

View reviewed changes

cubic-dev-ai bot reviewed Jul 15, 2025

View reviewed changes

vercel bot deployed to Preview July 15, 2025 21:07 View deployment

greptile

71190df

vercel bot deployed to Preview July 15, 2025 21:42 View deployment

Weves merged commit 3bb58a3 into main Jul 15, 2025
13 of 14 checks passed

Weves deleted the persona-simplification-r2 branch July 15, 2025 21:51

Weves added a commit that referenced this pull request Jul 15, 2025

Persona simplification r2 (#5031)

8646247

* Revert "Revert "Reduce amount of stuff we fetch on `/persona` (#4988)" (#5024)" This reverts commit f7ed7cd. * Enhancements / fix re-render * re-arrange * greptile

Weves added a commit that referenced this pull request Aug 20, 2025

Persona simplification r2 (#5031)

56fc8aa

* Revert "Revert "Reduce amount of stuff we fetch on `/persona` (#4988)" (#5024)" This reverts commit f7ed7cd. * Enhancements / fix re-render * re-arrange * greptile

	return [DocumentSetSummary.from_model(ds) for ds in document_sets]
	return [DocumentSetSummary.from_model(document_set) for document_set in document_sets]

	persona_snapshots = list(
	persona_snapshots: list[Persona] = list(

Persona simplification r2 #5031

Persona simplification r2 #5031

Uh oh!

Conversation

Weves commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Backporting (check the box to trigger backport action)

Summary by cubic

Uh oh!

vercel bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Greptile Summary

Confidence score: 4 /5

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Weves commented Jul 15, 2025 •

edited

Loading

vercel bot commented Jul 15, 2025 •

edited

Loading