-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: Env var for community-supported connectors #5043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This PR introduces a new feature flag to control the visibility of community-supported connectors in Onyx's UI, along with a significant reorganization of connector categories for better clarity. The changes span across both frontend and backend, implementing a consistent way to distinguish between officially supported connectors and those maintained by the community.
Key changes:
- Added
SHOW_EXTRA_CONNECTORS
environment variable (defaults to false) - Reorganized connectors into more specific categories (e.g., moving from generic 'Other' to specific categories like 'Sales & Marketing')
- Updated category names to be more descriptive (e.g., 'Storage' → 'Web Crawl & File Storage')
- Added settings integration to control connector visibility
- Removed the
NOT_APPLICABLE
value fromBlobType
enum as part of cleanup
This change helps organizations better manage their connector offerings by providing control over which integrations are visible to users, particularly useful for enterprise deployments where limiting to officially supported connectors may be desired.
Confidence score: 4 /5
- This PR is generally safe to merge with minimal risk of breaking existing functionality
- The changes are well-structured and follow existing patterns, but the removal of BlobType.NOT_APPLICABLE warrants careful testing of internet search functionality
- Files needing attention:
backend/onyx/configs/constants.py
: Verify internet search still works after BlobType enum changeweb/src/app/admin/add-connector/page.tsx
: Ensure proper error handling for settings context
12 files reviewed, 7 comments
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cubic reviewed 12 files and found no issues. Review PR in cubic.dev.
|
||
# NOTE: Generative AI configurations are done via the UI now | ||
|
||
EXA_API_KEY= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EXA_API_KEY=
Looks uncomplete
… to be running) (#5041) * Move around tests * Add missing fixtures + change directory structure up some more * Add env variables
* Improve check_for_indexing + check_for_vespa_sync_task * Remove unused * Fix * Simplify query * Add more logging * Address bot comments * Increase # of tasks generated since we're not going cc-pair by cc-pair * Only index 50 user files at a time
* Improve assistant fetching efficiency * More fix * Fix weird build stuff * Improve
* improvements * drop views if SQL fails * mypy fix
* aefads * search quality tests improvement Co-authored-by: wenxi-onyx <wenxi@onyx.app> * nits * refactor: config refactor * document context + skip genai fix * feat: answer eval * more error messages * mypy ragas * mypy * small fixes * feat: more metrics * fix * feat: grab content * typing * feat: lazy updates * mypy * all at front * feat: answer correctness * use api key so it works with auth enabled * update readme * feat: auto add path * feat: rate limit * fix: readme + remove rerank all * fix: raise exception immediately * docs: improved clarity * feat: federated handling * fix: mypy * nits --------- Co-authored-by: wenxi-onyx <wenxi@onyx.app>
* Update KG admin UI * Styling changes * More changes * Make edits auto-save * Add more stylings / transitions * Fix opacity * Separate out modal into new component * Revert backend changes * Update styling * Add convenience / styling changes to date-picker * More styling / functional updates to kg admin-page * Avoid reducing opacity of active-toggle * Update backend APIs for new KG admin page * More updates of styling for kg-admin page * Remove nullability * Remove console log * Remove unused imports * Change type of `children` variable * Update web/src/app/admin/kg/interfaces.ts Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> * Update web/src/components/CollapsibleCard.tsx Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> * Remove null * Update web/src/components/CollapsibleCard.tsx Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Force non-null * Fix failing test --------- Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
* WIP * renamed and moved tasks (WIP) * minio migration * bug fixes and finally add document batch storage * WIP: can suceed but status is error * WIP * import fixes * working v1 of decoupled * catastrophe handling * refactor * remove unused db session in prep for new approach * renaming and docstrings (untested) * renames * WIP with no more indexing fences * robustness improvements * clean up rebase * migration and salesforce rate limits * minor tweaks * test fix * connector pausing behavior * correct checkpoint resumption logic * cleanups in docfetching * add heartbeat file * update template jsonc * deployment fixes * fix vespa httpx pool * error handling * cosmetic fixes * dumb * logging improvements and non checkpointed connector fixes * didnt save * misc fixes * fix import * fix deletion of old files * add in attempt prefix * fix attempt prefix * tiny log improvement * minor changes * fixed resumption behavior * passing int tests * fix unit test * fixed unit tests * trying timeout bump to see if int tests pass * trying timeout bump to see if int tests pass * fix autodiscovery * helm chart fixes * helm and logging
… Conventional Commits regex (#5062)
* fix time discrepancy * remove log * remove log
* nit var clarity * maintain file names in connector config for display * remove unused util * migration draft * optional file names to not break existing instances * backwards compatible * backwards compatible * migration logging * update file ocnn tests * unncessary none * mypy + explanatory comments
* fix unsupported character error in minio migration * slash fix
* Add customization via env vars for curator role * Simplify * Simplify more * Address comments
* feat(infra): Adding helm directory * one more fix
* fix slash command slackbot to respond in private msg * rename confusing variable. fix slash message response in DMs
* feat(infra): Bump Vespa Helm Version * Adding the Chart.lock file
* WIP merged approach untested * tested custom configs * JT comments * fix unit test * CW comments * fix unit test
* fix: remove erroneous error case and add valid error * also address docfetching-docprocessing limbo
* support gpt5 models * gpt5mini visible
* switch to markitdown untested * passing tests * reset file * dotenv version * docs * add test file * add doc * fix integration test
* file processing refactor * mypy * CW comments * address CW
* sanitize slack payload before logging * nit
* fix(infra): Update github workflow to not tag latest * Cleaned up the code a bit
* fix: restrict user file access to current user only * fix: enhance user file access control for recent folder
* initial migration * getting metadata from tags * complete migration * migration override for cloud * fix: more robust structured tag gen * tag and indexing update * fix: move is_list to tags * migration rebase * test cases + bugfix on unique constraint * fix logging
* max tokens param * fix unit test * fix unit test
* sharepoint perm sync first draft * feat: Implement SharePoint permission synchronization * mypy fix * remove commented code * bot comments fixes and job failure fixes * introduce generic way to upload certificates in credentials * mypy fix * add checkpoiting to sharepoint connector * add sharepoint integration tests * Refactor SharePoint connector to derive tenant domain from verified domains and remove direct tenant domain input from credentials * address review comments * add permission sync to site pages * mypy fix * fix tests error * fix tests and address comments * Update file extraction behavior in SharePoint connector to continue processing on unprocessable files
Description
How Has This Been Tested?
local
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.