Skip to content

fix: Make ungrounded types have a default name when sending to the frontend #5133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 30, 2025
Merged

fix: Make ungrounded types have a default name when sending to the frontend #5133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9980db6
Update names in map-comprehension
raunakab Jul 30, 2025
72b5709
Make default name for ungrounded types public
raunakab Jul 30, 2025
ba66f5d
Return the default name for ungrounded entity-types
raunakab Jul 30, 2025
aaa8e7a
Update backend/onyx/db/entities.py
raunakab Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion backend/onyx/db/entities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
from sqlalchemy.orm import Session

import onyx.db.document as dbdocument
from onyx.db.entity_type import UNGROUNDED_SOURCE_NAME
from onyx.db.models import Document
from onyx.db.models import KGEntity
from onyx.db.models import KGEntityExtractionStaging
Expand Down Expand Up @@ -328,7 +329,13 @@ def get_entity_stats_by_grounded_source_name(
.group_by(KGEntityType.grounded_source_name)
.all()
)

# `row.grounded_source_name` is NULLABLE in the database schema.
# Thus, for all "ungrounded" entity-types, we use a default name.
return {
row.grounded_source_name: (row.last_updated, row.entities_count)
(row.grounded_source_name or UNGROUNDED_SOURCE_NAME): (
row.last_updated,
row.entities_count,
)
for row in results
}
4 changes: 2 additions & 2 deletions backend/onyx/db/entity_type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from onyx.server.kg.models import EntityType


_UNGROUNDED_SOURCE_NAME = "Ungrounded"
UNGROUNDED_SOURCE_NAME = "Ungrounded"


def get_entity_types_with_grounded_source_name(
Expand Down Expand Up @@ -87,7 +87,7 @@ def get_configured_entity_types(db_session: Session) -> dict[str, list[KGEntityT

et_map = defaultdict(list)
for et in ets:
key = et.grounded_source_name or _UNGROUNDED_SOURCE_NAME
key = et.grounded_source_name or UNGROUNDED_SOURCE_NAME
et_map[key].append(et)

return et_map
Expand Down
14 changes: 9 additions & 5 deletions backend/onyx/server/kg/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,15 +179,19 @@ def get_kg_entity_types(
) -> SourceAndEntityTypeView:
# when using for the first time, populate with default entity types
entity_types = {
key: [EntityType.from_model(et) for et in ets]
for key, ets in get_configured_entity_types(db_session=db_session).items()
source_name: [EntityType.from_model(et) for et in ets]
for source_name, ets in get_configured_entity_types(
db_session=db_session
).items()
}

source_statistics = {
key: SourceStatistics(
source_name=key, last_updated=last_updated, entities_count=entities_count
source_name: SourceStatistics(
source_name=source_name,
last_updated=last_updated,
entities_count=entities_count,
)
for key, (
for source_name, (
last_updated,
entities_count,
) in get_entity_stats_by_grounded_source_name(db_session=db_session).items()
Expand Down
Loading