Skip to content

Conversation

wenxi-onyx
Copy link
Member

@wenxi-onyx wenxi-onyx commented Aug 8, 2025

Description

title

How Has This Been Tested?

locally

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

@wenxi-onyx wenxi-onyx requested a review from a team as a code owner August 8, 2025 23:56
Copy link

vercel bot commented Aug 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 11:56pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR adds display names for two new GPT-5 models to the MODEL_DISPLAY_NAMES constant in web/src/lib/hooks.ts. The changes map the technical model identifiers gpt-5 and gpt-5-mini to their user-friendly display names GPT 5 and GPT 5 Mini respectively.

The MODEL_DISPLAY_NAMES constant is used by the getDisplayNameForModel function to convert raw model names into readable names that users see in the interface. This ensures consistency across the UI when displaying model options, preventing users from seeing technical identifiers like gpt-5 and instead showing polished names like GPT 5. The implementation follows the existing pattern in the codebase and maintains alphabetical ordering within the OpenAI models section.

This change is part of the broader model management system in Onyx, where various LLM providers and their models are supported. The display names help create a more professional and user-friendly experience when users are selecting or viewing which models are being used for their queries.

PR Description Notes:

  • The description is minimal ("title") and could be more descriptive
  • Testing description is vague ("locally") - could specify what was tested

Confidence score: 5/5

  • This PR is extremely safe to merge with virtually no risk of issues
  • Score reflects the minimal, straightforward nature of adding two constant string mappings with no logic changes
  • No files require special attention as this is a simple addition to an existing constant object

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic analysis

No issues found across 1 file. Review in cubic

@Weves Weves merged commit 297c295 into main Aug 8, 2025
16 of 18 checks passed
@Weves Weves deleted the bugfix/gpt5_display_names branch August 8, 2025 23:58
wenxi-onyx added a commit that referenced this pull request Aug 9, 2025
(cherry picked from commit 297c295)
wenxi-onyx added a commit that referenced this pull request Aug 11, 2025
AnkitTukatek pushed a commit to TukaTek/onyx that referenced this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants