feat: reorganize connectors pages #5186
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Greptile Summary
This PR implements a comprehensive reorganization of the connector management interface to improve user experience through better categorization and selective visibility. The changes introduce a "Popular" section that prominently displays commonly used connectors (Slack, Google Drive, GitHub, etc.) at the top of the page when no search is active. The "Other" category has been repurposed to contain uncommon/extra connectors, which can now be hidden via a new environment variable SHOW_EXTRA_CONNECTORS.
The implementation spans multiple layers of the application:
Backend Changes: Added the SHOW_EXTRA_CONNECTORS environment variable to app_configs.py (defaults to false), integrated it into the Settings model and store, creating a complete configuration pipeline from environment to frontend.
Data Reorganization: The sources.ts file was extensively reorganized with connectors now grouped by logical categories (Cloud Storage, Code Repository, Customer Support, etc.) and sorted alphabetically within each category. Eleven popular connectors were flagged with isPopular: true, and some connectors were recategorized (notably 'file' moved to Other, new 'Sales & Marketing' category created).
Frontend Logic: The add-connector page now renders a Popular section when no search term is active, and conditionally filters out the Other category based on the settings. Category descriptions were removed to reduce visual clutter.
Infrastructure: All Docker Compose configurations were updated with the new environment variable, defaulting to true in development environments for backward compatibility.
Interface Updates: The SourceCategory enum was updated with more descriptive names ('Storage' → 'Cloud Storage', 'CustomerRelationshipManagement' → 'Sales & Marketing'), and the SourceMetadata interface gained the isPopular boolean field.
The changes integrate cleanly with existing components like SourceTileTooltipWrapper and maintain compatibility with federated connectors and credential checking logic. The reorganization follows established patterns in the codebase for environment variable configuration and settings management.
Confidence score: 4/5
- This PR introduces significant UI reorganization with new filtering logic but appears well-implemented with proper environment variable integration
- Score reflects complexity in the filtering logic and potential edge cases in search behavior, though the core changes follow established patterns
- Pay close attention to the add-connector page filtering logic and ensure the popular connectors section behaves correctly across different search states
12 files reviewed, 3 comments
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic analysis
No issues found across 12 files. Review in cubic
* Add popular connectors sections and cleanup connectors page * Add other connectors env var * other connectors env var to vscode env template * update playwright tests * sort by popuarlity * recategorize and sort by popularity
Description
How Has This Been Tested?
locally
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.