fix: seeded total doc count #5188
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Greptile Summary
This PR fixes a bug in the document seeding flow by adding a call to mark_document_as_indexed_for_cc_pair__no_commit in the seed_initial_documents function. The change ensures that seeded documents are properly marked as indexed in the DocumentByConnectorCredentialPair table after being indexed into Vespa.
The issue was that the seeding process was successfully indexing documents into the Vespa search engine and updating their chunk counts in the database, but it wasn't marking these documents as indexed in the relationship table that tracks which documents have been processed for each connector-credential pair. This created an inconsistent state where documents were searchable but the system didn't properly track their indexed status.
The fix is strategically placed after the Vespa indexing operation but before the mock index attempt creation, ensuring the database state accurately reflects the indexed documents while maintaining transactional consistency by using the __no_commit variant of the function.
Confidence score: 4/5
- This PR is safe to merge with minimal risk of breaking existing functionality
- Score reflects a straightforward bug fix that addresses a clear state inconsistency issue without modifying critical logic flows
- Pay close attention to the placement of the new function call to ensure it maintains proper transactional boundaries
1 file reviewed, no comments
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic analysis
No issues found across 1 file. Review in cubic
* fix seeded total doc count * fix seeded total doc count
2 participants
Description
How Has This Been Tested?
-locally
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.
Summary by cubic
Fixed seeded document count by marking documents as indexed during the seeding process to ensure accurate totals.