fix: sharepoint group not found error and url with apostrophe

[Subash-Mohan]

Description

This pull request enhances SharePoint external permissions handling by improving error handling, logging, and reliability when interacting with SharePoint and Azure AD groups. The most important changes include better handling of missing groups, improved logging for debugging, and a more robust approach to retrieving site page permissions.

How Has This Been Tested?

Tested by creating the connector

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

• This PR should be backported (make sure to check that the backport attempt succeeds)
• [Optional] Override Linear Check

---

Summary by cubic

Fixes SharePoint permission fetching by skipping deleted Azure AD groups and correctly handling site page URLs with apostrophes. Adds safer retries and logging to improve reliability.

• Bug Fixes
  • Skip Azure AD groups that return 404 during traversal; log and continue instead of failing.
  • Resolve site page permission lookups for URLs with apostrophes by using server‑relative paths.
  • Wrap permission queries with retries and null‑safe error checks; improve 429 rate‑limit logging.
  • Add targeted logs for users, members, and role assignments to help debug permission issues.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
internal-search	Ready	Preview	Comment	Aug 18, 2025 6:37am

[greptile-apps]

Greptile Summary

This PR enhances the SharePoint connector's error handling and reliability by addressing two key areas: null safety in retry logic and external permissions processing. The changes improve how the connector handles missing Azure AD groups and URL parsing issues while adding extensive debugging capabilities.

In the main SharePoint connector (connector.py), the PR replaces implicit boolean checks with explicit null checks in the retry mechanism. Instead of using e.response (which could potentially raise exceptions if the response object's __bool__ method behaves unexpectedly), the code now uses e.response is not None. This defensive programming approach ensures the retry logic remains robust when handling ClientRequestException objects from the SharePoint API.

The more substantial changes are in the external permissions module (permission_utils.py), which handles retrieving and processing SharePoint access permissions. The PR adds comprehensive error handling for scenarios where SharePoint references Azure AD groups that have been deleted, wrapping Azure AD group retrieval in try-catch blocks to gracefully handle 404 errors. Additionally, it fixes URL parsing issues by switching from OData filter approaches to server-relative URL parsing, which resolves problems with SharePoint sites containing apostrophes in their URLs that would break OData filters.

The changes also introduce extensive debug logging throughout the permission processing pipeline, outputting detailed information about users, members, and permission assignments. This logging enhancement supports troubleshooting and monitoring of the SharePoint integration, though it significantly increases the verbosity of debug output.

These modifications align with the codebase's principles of defensive programming and explicit error handling, particularly the preference for failing loudly rather than silently. The external permissions improvements make the connector more resilient to real-world SharePoint/Azure AD inconsistencies.

Confidence score: 3/5

• This PR addresses real issues but introduces extensive debug logging that may impact performance and expose sensitive data in production
• Score reflects concerns about the volume of debug logging and potential performance implications in production environments
• Pay close attention to the external permissions file due to extensive logging additions and error handling changes

_{2 files reviewed, 1 comment}

_{Edit Code Review Bot Settings | Greptile}

[cubic-dev-ai]

cubic analysis

No issues found across 2 files. Review in cubic