chore(packages): Move @types packages to devDependencies #5210
Conversation
|
@camro is attempting to deploy a commit to the Danswer Team on Vercel. A member of the Team first needs to authorize it. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Greptile Summary
This PR moves TypeScript type definition packages from dependencies to devDependencies in the web application's package.json file. The following @types/* packages were relocated:
@types/js-cookie(updated from 3.0.3 to 3.0.6)@types/lodash(updated from 4.17.0 to 4.17.20)@types/node@types/prismjs@types/react@types/react-dom@types/uuid
This change follows JavaScript/TypeScript best practices, as type definition packages are only needed during development, TypeScript compilation, and build processes - they provide no runtime functionality. The relocation optimizes the production dependency tree by reducing the number of packages that need to be installed in production environments, while maintaining all necessary type safety during development.
The change aligns with the existing project structure where other development-only tools like ESLint, Jest, Prettier, and testing frameworks are already properly categorized in devDependencies. Two of the moved packages received minor version updates to their latest compatible versions as part of this refactoring.
Confidence score: 5/5
- This PR is extremely safe to merge with no risk of production issues
- Score reflects a straightforward dependency categorization following established best practices
- No files require special attention as this is a simple package.json optimization
1 file reviewed, no comments
camro
changed the title
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Description
Type dependencies are only needed in the dev/build environment
How Has This Been Tested?
Backporting (check the box to trigger backport action)
Summary by cubic
Moved all TypeScript @types packages to devDependencies so they aren’t installed in production, reducing install size and keeping runtime deps lean. Also bumped @types/js-cookie and @types/lodash to the latest patch versions.