Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/onyx/auth/users.py
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ def verify_email_domain(email: str) -> None:
status_code=status.HTTP_400_BAD_REQUEST,
detail="Email is not valid",
)
domain = email.split("@")[-1]
domain = email.split("@")[-1].lower()
if domain not in VALID_EMAIL_DOMAINS:
raise HTTPException(
status_code=status.HTTP_400_BAD_REQUEST,
Expand Down
6 changes: 5 additions & 1 deletion backend/onyx/configs/app_configs.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,11 @@
os.environ.get("VALID_EMAIL_DOMAINS", "") or _VALID_EMAIL_DOMAIN
)
VALID_EMAIL_DOMAINS = (
[domain.strip() for domain in _VALID_EMAIL_DOMAINS_STR.split(",")]
[
domain.strip().lower()
for domain in _VALID_EMAIL_DOMAINS_STR.split(",")
if domain.strip()
]
if _VALID_EMAIL_DOMAINS_STR
else []
)
Expand Down
37 changes: 37 additions & 0 deletions backend/tests/unit/onyx/auth/test_verify_email_domain.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
import pytest
from fastapi import HTTPException

import onyx.auth.users as users
from onyx.auth.users import verify_email_domain


def test_verify_email_domain_allows_case_insensitive_match(
monkeypatch: pytest.MonkeyPatch,
) -> None:
# Configure whitelist to lowercase while email has uppercase domain
monkeypatch.setattr(users, "VALID_EMAIL_DOMAINS", ["example.com"], raising=False)

# Should not raise
verify_email_domain("User@EXAMPLE.COM")


def test_verify_email_domain_rejects_non_whitelisted_domain(
monkeypatch: pytest.MonkeyPatch,
) -> None:
monkeypatch.setattr(users, "VALID_EMAIL_DOMAINS", ["example.com"], raising=False)

with pytest.raises(HTTPException) as exc:
verify_email_domain("user@another.com")
assert exc.value.status_code == 400
assert "Email domain is not valid" in exc.value.detail


def test_verify_email_domain_invalid_email_format(
monkeypatch: pytest.MonkeyPatch,
) -> None:
monkeypatch.setattr(users, "VALID_EMAIL_DOMAINS", ["example.com"], raising=False)

with pytest.raises(HTTPException) as exc:
verify_email_domain("userexample.com") # missing '@'
assert exc.value.status_code == 400
assert "Email is not valid" in exc.value.detail
Loading