Skip to content

Conversation

wenxi-onyx
Copy link
Member

@wenxi-onyx wenxi-onyx commented Aug 21, 2025

Description

This PR resolves dark mode readability issues by replacing hardcoded color values (e.g., hex codes, text-black without dark variants) with semantic Tailwind CSS classes and their corresponding dark mode variants. This ensures all text, backgrounds, and UI elements adapt correctly to the user's selected theme, improving consistency and accessibility.

How Has This Been Tested?

Visually verified all affected components in both light and dark modes to ensure correct color rendering and readability.

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

Slack Thread

Open in Cursor Open in Web

Summary by cubic

Replaced hardcoded color values with semantic Tailwind classes and dark mode variants to fix dark mode readability and ensure consistent theming across the app.

  • Bug Fixes
    • Removed hex-based colors (e.g., #000, #fff) and text-black in favor of white/black or semantic tokens with dark: variants.
    • Improved contrast in dark mode for text and errors (e.g., text-strong, dark:text-white, dark:text-neutral-300/400, dark:text-red-400).
    • Standardized dark backgrounds and hovers (e.g., dark:bg-neutral-800/900/950, neutral hover shades) for consistent visuals.
    • Updated overlays, popovers, and tooltips to use theme-aware backgrounds (e.g., bg-black/50, dark variants) for better readability.

Copy link

cursor bot commented Aug 21, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

Copy link

vercel bot commented Aug 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
internal-search Ready Ready Preview Comment Aug 21, 2025 5:27am

Co-authored-by: wenxi <wenxi@onyx.app>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants