feat(docprocessing): Adding additional logs #5239
Conversation
* fix: use only celery-shared for security context * fix: bump helm chart version 0.2.8
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Greptile Summary
This PR adds logging capabilities to the document processing heartbeat functionality to improve observability and debugging. The changes introduce proper logging for both successful heartbeat counter updates and failures in the indexing worker system.
Specifically, the PR:
- Imports the
setup_logger()function fromonyx.utils.logger - Adds debug-level logging when heartbeat counters are successfully updated for index attempts
- Replaces a silent
passstatement with proper exception logging that captures full stack traces when heartbeat updates fail
This change integrates with the existing logging infrastructure by using the OnyxLoggingAdapter that adds contextual information like request IDs and tenant IDs to log messages. The heartbeat system is a critical component for tracking the health of document indexing workers, and previously any failures were silently ignored, making it impossible to diagnose issues. This logging enhancement will provide the visibility needed to investigate heartbeat problems mentioned in the PR description.
Confidence score: 5/5
- This PR is extremely safe to merge with virtually no risk of causing issues
- Score reflects simple, well-contained logging additions that follow established patterns and improve observability without changing core logic
- No files require special attention as the changes are straightforward logging enhancements
1 file reviewed, no comments
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
…nyx-dot-app#5239) * fix: use only celery-shared for security context * fix: bump helm chart version 0.2.8 Co-authored-by: Sam Waddell <shwaddell28@gmail.com>
Description
[Provide a brief description of the changes in this PR]
We need to add additional logging in order to investigate why there are issues with the logging of the heartbeat and understand why there is an issue.
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.