-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(infra): Adding rety to Trivy tests #5383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This review covers only the changes made since the last review, not the entire PR. The most recent changes address the timeout issue identified in the previous review by increasing the retry action timeout from 25 to 30 minutes across all four Docker build workflow files. This provides a 10-minute buffer between the Trivy scanner's internal 20-minute timeout and the retry wrapper timeout, resolving the timing conflict that could have caused premature retry failures. The change maintains the existing retry configuration (3 attempts, 10-second intervals) while giving each attempt sufficient time to complete. These modifications are part of a systematic effort to make the CI/CD pipeline more resilient to Trivy's known reliability issues without requiring manual intervention during deployments.
Confidence score: 5/5
- This PR is safe to merge with minimal risk as it only adjusts timeout values in existing retry mechanisms
- Score reflects addressing of previous reviewer feedback and implementation of a straightforward timeout buffer increase
- No files require special attention as the changes are consistent and well-tested timeout adjustments
4 files reviewed, no comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 issues found across 4 files
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai
to give feedback, ask questions, or re-run the review.
Description
[Provide a brief description of the changes in this PR]
Adding retry logic to the Trivy scanning since this job is flaky and causes us to be blocked and waiting at times.
This should allow us to not have to babysit the tests to pass moving forward for deploy and image builds.
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Tested with a test tag and validated that the github actions were functioning properly and retrying when necessary.
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.