Skip to content

Conversation

justin-tahara
Copy link
Contributor

@justin-tahara justin-tahara commented Sep 10, 2025

Description

[Provide a brief description of the changes in this PR]
Adding retry logic to the Trivy scanning since this job is flaky and causes us to be blocked and waiting at times.

This should allow us to not have to babysit the tests to pass moving forward for deploy and image builds.

How Has This Been Tested?

[Describe the tests you ran to verify your changes]
Tested with a test tag and validated that the github actions were functioning properly and retrying when necessary.

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

@justin-tahara justin-tahara requested a review from a team as a code owner September 10, 2025 00:28
Copy link

vercel bot commented Sep 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
internal-search Ready Ready Preview Comment Sep 10, 2025 0:36am

greptile-apps[bot]

This comment was marked as outdated.

@justin-tahara
Copy link
Contributor Author

@greptileai

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This review covers only the changes made since the last review, not the entire PR. The most recent changes address the timeout issue identified in the previous review by increasing the retry action timeout from 25 to 30 minutes across all four Docker build workflow files. This provides a 10-minute buffer between the Trivy scanner's internal 20-minute timeout and the retry wrapper timeout, resolving the timing conflict that could have caused premature retry failures. The change maintains the existing retry configuration (3 attempts, 10-second intervals) while giving each attempt sufficient time to complete. These modifications are part of a systematic effort to make the CI/CD pipeline more resilient to Trivy's known reliability issues without requiring manual intervention during deployments.

Confidence score: 5/5

  • This PR is safe to merge with minimal risk as it only adjusts timeout values in existing retry mechanisms
  • Score reflects addressing of previous reviewer feedback and implementation of a straightforward timeout buffer increase
  • No files require special attention as the changes are consistent and well-tested timeout adjustments

4 files reviewed, no comments

Edit Code Review Bot Settings | Greptile

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 4 files

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

@Weves Weves merged commit a79ab71 into main Sep 10, 2025
16 checks passed
@Weves Weves deleted the jtahara/new-retry-logic-trivy branch September 10, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants