Skip to content

Conversation

wenxi-onyx
Copy link
Member

@wenxi-onyx wenxi-onyx commented Sep 10, 2025

Description

[Provide a brief description of the changes in this PR]

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

@wenxi-onyx wenxi-onyx requested a review from a team as a code owner September 10, 2025 21:39
Copy link

vercel bot commented Sep 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
internal-search Ready Ready Preview Comment Sep 10, 2025 9:44pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR removes the langchain-community==0.3.21 dependency from backend/requirements/default.txt. The change represents a strategic cleanup of the dependency footprint, aligning with LangChain's architectural evolution. Starting from LangChain 0.2.0, the project officially recommends removing the dependency on langchain-community from the main langchain package. The Onyx codebase has evolved to use langchain-core (version 0.3.51) for essential functionality like message types and interfaces, while implementing custom LLM integrations through litellm rather than relying on community-maintained langchain integrations. This change reduces the security surface area and dependency complexity while maintaining all necessary functionality through langchain-core and the existing custom implementations. The remaining dependencies langchain-core==0.3.51 and langchain==0.3.23 provide all the required LangChain functionality for the codebase.

PR Description Notes:

  • The PR description is incomplete with placeholder text that should be filled out
  • Missing actual description of changes and testing details

Confidence score: 4/5

  • This PR is safe to merge with minimal risk as it removes an unused dependency without affecting functionality
  • Score reflects careful analysis showing no direct imports from langchain_community in the codebase and proper retention of required langchain-core functionality
  • Pay close attention to runtime testing to ensure no hidden dependencies exist that weren't caught in static analysis

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@wenxi-onyx wenxi-onyx merged commit 2b1c5a0 into main Sep 11, 2025
52 of 53 checks passed
@wenxi-onyx wenxi-onyx deleted the whuang/remove-lc-community branch September 11, 2025 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant