Skip to content

Conversation

wenxi-onyx
Copy link
Member

@wenxi-onyx wenxi-onyx commented Sep 16, 2025

Description

[Provide a brief description of the changes in this PR]

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

Summary by cubic

Improve README phrasing in the connectors sentence for clarity and consistency. Replaces “..., Confluence, Salesforce, etc.” with “..., Confluence, and Salesforce.”

@wenxi-onyx wenxi-onyx requested a review from a team as a code owner September 16, 2025 19:37
Copy link

vercel bot commented Sep 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
internal-search Building Building Preview Comment Sep 16, 2025 7:37pm

@wenxi-onyx wenxi-onyx closed this Sep 16, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR makes a minor editorial improvement to the README.md file by replacing "etc." with "and Salesforce" on line 29. The change transforms the sentence from ending with a vague "etc." to explicitly mentioning Salesforce as a named connector, improving the clarity and professionalism of the documentation. This is a purely cosmetic change that follows good documentation practices by being more specific about the platform's capabilities rather than using indefinite terminology.

The change fits well within the broader context of the README file, which consistently mentions specific connector names throughout the document. This editorial improvement maintains consistency with the rest of the documentation's approach of explicitly naming supported platforms rather than relying on abbreviations.

PR Description Notes:

  • The PR description sections are left with placeholder text and haven't been filled out by the contributor
  • The backporting checkboxes remain unchecked, indicating no backport is needed for this documentation change

Confidence score: 5/5

  • This PR is safe to merge with minimal risk as it only contains a minor documentation improvement
  • Score reflects the purely editorial nature of the change with zero functional impact on the codebase
  • No files require special attention as this is a simple one-line text change in documentation

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="README.md">

<violation number="1" location="README.md:29">
Use &quot;synced&quot; instead of &quot;sync-ed&quot; for standard spelling.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

<strong>[Onyx](https://www.onyx.app/)</strong> (formerly Danswer) is the AI platform connected to your company's docs, apps, and people.
Onyx provides a feature rich Chat interface and plugs into any LLM of your choice.
Keep knowledge and access controls sync-ed across over 40 connectors like Google Drive, Slack, Confluence, Salesforce, etc.
Keep knowledge and access controls sync-ed across over 40 connectors like Google Drive, Slack, Confluence, and Salesforce.
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "synced" instead of "sync-ed" for standard spelling.

Prompt for AI agents
Address the following comment on README.md at line 29:

<comment>Use &quot;synced&quot; instead of &quot;sync-ed&quot; for standard spelling.</comment>

<file context>
@@ -26,7 +26,7 @@
 &lt;strong&gt;[Onyx](https://www.onyx.app/)&lt;/strong&gt; (formerly Danswer) is the AI platform connected to your company&#39;s docs, apps, and people.
 Onyx provides a feature rich Chat interface and plugs into any LLM of your choice.
-Keep knowledge and access controls sync-ed across over 40 connectors like Google Drive, Slack, Confluence, Salesforce, etc.
+Keep knowledge and access controls sync-ed across over 40 connectors like Google Drive, Slack, Confluence, and Salesforce.
 Create custom AI agents with unique prompts, knowledge, and actions that the agents can take.
 Onyx can be deployed securely anywhere and for any scale - on a laptop, on-premise, or to cloud.
</file context>
Suggested change
Keep knowledge and access controls sync-ed across over 40 connectors like Google Drive, Slack, Confluence, and Salesforce.
Keep knowledge and access controls synced across over 40 connectors like Google Drive, Slack, Confluence, and Salesforce.
Fix with Cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant