Skip to content

Conversation

justin-tahara
Copy link
Contributor

@justin-tahara justin-tahara commented Sep 16, 2025

Reverts #5431


Summary by cubic

Restores the Helm chart to its previous configuration by reverting the recent KEDA change.

  • Dependencies
    • Removed keda (2.14.2) from Chart.yaml dependencies.
    • Rolled chart version back from 0.3.1 to 0.3.0.

@justin-tahara justin-tahara requested a review from a team as a code owner September 16, 2025 23:47
Copy link

vercel bot commented Sep 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
internal-search Building Building Preview Comment Sep 16, 2025 11:47pm

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@justin-tahara justin-tahara merged commit 770a269 into main Sep 16, 2025
19 of 25 checks passed
@justin-tahara justin-tahara deleted the revert-5431-jtahara/add-keda-dependency branch September 16, 2025 23:48
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR reverts the addition of KEDA (Kubernetes Event Driven Autoscaling) as a dependency from the Onyx Helm chart. The change removes the KEDA dependency entry from Chart.yaml and downgrades the chart version from 0.3.1 back to 0.3.0.

KEDA is a Kubernetes-native autoscaling component that allows applications to scale based on event sources like message queues, metrics, or external triggers. In the context of Onyx's architecture, KEDA would enable automatic scaling of components like the web server, API, and Celery workers based on workload demands.

The revert specifically removes:

  • The KEDA dependency declaration (name: keda, version: 2.14.2, repository: https://kedacore.github.io/charts)
  • Downgrades the chart version to reflect the removal

This change integrates with the broader Helm chart ecosystem where Onyx depends on multiple external charts (PostgreSQL, Redis, MinIO, etc.) to provide a complete deployment stack. By removing KEDA, the chart reduces its complexity and external dependencies, though this may limit autoscaling capabilities for production deployments.

Confidence score: 2/5

  • This PR creates significant inconsistency issues that could confuse users and cause deployment problems
  • Score reflects incomplete revert that leaves orphaned KEDA configurations in values.yaml while removing the dependency needed to support them
  • Pay close attention to the values.yaml file and any templates that reference KEDA autoscaling features

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant