Skip to content

Conversation

justin-tahara
Copy link
Contributor

@justin-tahara justin-tahara commented Sep 16, 2025

Description

[Provide a brief description of the changes in this PR]
The chart releaser did not have the kedacore chart so it failed to build

How Has This Been Tested?

[Describe the tests you ran to verify your changes]
Will run in CI

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

@justin-tahara justin-tahara requested a review from a team as a code owner September 16, 2025 23:58
Copy link

vercel bot commented Sep 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
internal-search Building Building Preview Comment Sep 16, 2025 11:58pm

@justin-tahara justin-tahara merged commit 14ead45 into main Sep 16, 2025
17 of 20 checks passed
@justin-tahara justin-tahara deleted the jtahara/fix-chart-releaser branch September 16, 2025 23:58
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR fixes a build failure in the Helm chart release workflow by adding the missing KEDA repository configuration. The onyx-stack Helm chart declares a dependency on KEDA version 2.17.2 from the kedacore repository in its Chart.yaml, but the helm-chart-releases.yml workflow was only configured to add bitnami and onyx-vespa repositories during the chart building process.

The fix adds helm repo add keda https://kedacore.github.io/charts to the "Add required Helm repositories" step in the release workflow, ensuring that all chart dependencies can be resolved during the build process. This brings the chart releaser workflow in line with the chart's actual dependencies and prevents build failures when Helm attempts to fetch the KEDA chart dependency.

The change is minimal and surgical, affecting only the repository configuration step without modifying any chart logic or deployment configurations. It also includes a formatting improvement by adding a trailing newline to the file.

Confidence score: 5/5

  • This PR is extremely safe to merge with virtually no risk of causing issues
  • Score reflects a simple, well-targeted fix that directly addresses a clear build failure with minimal scope
  • No files require special attention as this is a straightforward infrastructure configuration fix

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant