Skip to content

fix: braintrust masking was over truncating #5458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 19, 2025
+10 −8
Merged

fix: braintrust masking was over truncating #5458

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5aab51e
.
rguan72 Sep 19, 2025
09381a4
Update backend/onyx/evals/tracing.py
rguan72 Sep 19, 2025
72a1b49
.
rguan72 Sep 19, 2025
cfc10f5
.
rguan72 Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions backend/onyx/evals/tracing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,24 @@
from onyx.configs.app_configs import BRAINTRUST_API_KEY
from onyx.configs.app_configs import BRAINTRUST_PROJECT

MASKING_LENGTH = 20000

def _truncate_str(s: str, head: int = 800, tail: int = 200) -> str:
if len(s) <= head + tail:
return s
return f"{s[:head]}…{s[-tail:]}[TRUNCATED {len(s)} chars to 10,000]"

def _truncate_str(s: str) -> str:
tail = MASKING_LENGTH // 5
head = MASKING_LENGTH - tail
return f"{s[:head]}…{s[-tail:]}[TRUNCATED {len(s)} chars to {MASKING_LENGTH}]"


def _should_mask(data: Any) -> bool:
return len(str(data)) > MASKING_LENGTH


def _mask(data: Any) -> Any:
data_str = str(data)
if len(data_str) > 10_000:
return _truncate_str(data_str)
return data
"""Mask data if it exceeds the maximum length threshold."""
if not _should_mask(data):
return data
return _truncate_str(str(data))


def setup_braintrust() -> None:
Expand Down
Loading