Skip to content

Conversation

edwin-onyx
Copy link
Contributor

@edwin-onyx edwin-onyx commented Sep 23, 2025

Description

[Provide a brief description of the changes in this PR]

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

Summary by cubic

Cleaned up imports and disabled unused code across Celery, search, DB, and LLM modules to reduce circular dependencies and stabilize worker startup. No user-facing changes.

  • Refactors

    • Removed Vespa/Redis-related imports from Celery app base.
    • Dropped NLTK usage in search utils and commented out EmbeddingModel import.
    • Commented out KG entity doc info helpers in db.document to decouple agents.
    • Removed ToolCallFinalResult import in db.chat and unused type-checking imports in llm.utils.
    • Trimmed logging and file parsing imports in llm.utils; general import cleanup in docfetching tasks.
  • Dependencies

    • Removed NLTK as a runtime dependency in search utilities.

Copy link

vercel bot commented Sep 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
internal-search Ready Ready Preview Comment Sep 23, 2025 8:49pm

Copy link

blacksmith-sh bot commented Sep 23, 2025

12 Jobs Failed:

Run Integration Tests v2 / prepare-build failed on "Generate OpenAPI schema"
[...]
    from onyx.indexing.indexing_pipeline import run_indexing_pipeline
  File "/home/runner/_work/onyx/onyx/backend/onyx/indexing/indexing_pipeline.py", line 48, in <module>
    from onyx.db.user_documents import fetch_user_files_for_documents
  File "/home/runner/_work/onyx/onyx/backend/onyx/db/user_documents.py", line 27, in <module>
    from onyx.server.documents.connector import trigger_indexing_for_cc_pair
  File "/home/runner/_work/onyx/onyx/backend/onyx/server/documents/connector.py", line 99, in <module>
    from onyx.db.federated import fetch_all_federated_connectors_parallel
  File "/home/runner/_work/onyx/onyx/backend/onyx/db/federated.py", line 16, in <module>
    from onyx.federated_connectors.factory import get_federated_connector
  File "/home/runner/_work/onyx/onyx/backend/onyx/federated_connectors/factory.py", line 7, in <module>
    from onyx.federated_connectors.slack.federated_connector import SlackFederatedConnector
  File "/home/runner/_work/onyx/onyx/backend/onyx/federated_connectors/slack/federated_connector.py", line 11, in <module>
    from onyx.context.search.federated.slack_search import slack_retrieval
  File "/home/runner/_work/onyx/onyx/backend/onyx/context/search/federated/slack_search.py", line 28, in <module>
    from onyx.llm.factory import get_default_llms
  File "/home/runner/_work/onyx/onyx/backend/onyx/llm/factory.py", line 8, in <module>
    from onyx.db.llm import fetch_default_provider
ImportError: cannot import name 'fetch_default_provider' from 'onyx.db.llm' (/home/runner/_work/onyx/onyx/backend/onyx/db/llm.py)
CRITICAL: Exiting due to uncaught exception ImportError: cannot import name 'fetch_default_provider' from 'onyx.db.llm' (/home/runner/_work/onyx/onyx/backend/onyx/db/llm.py)
Error: Process completed with exit code 1.
Run Integration Tests v2 / required failed on "Run actions/github-script@v7"
[...]
  retry-exempt-status-codes: 400,401,403,404,422
env:
  PRIVATE_REGISTRY: experimental-registry.blacksmith.sh:5000
  PRIVATE_REGISTRY_USERNAME: ***
  PRIVATE_REGISTRY_PASSWORD: ***
  OPENAI_API_KEY: ***
  SLACK_BOT_TOKEN: ***
  CONFLUENCE_TEST_SPACE_URL: ***
  CONFLUENCE_USER_NAME: ***
  CONFLUENCE_ACCESS_TOKEN: ***
  JIRA_BASE_URL: ***
  JIRA_USER_EMAIL: ***
  JIRA_API_TOKEN: ***
  PERM_SYNC_SHAREPOINT_CLIENT_ID: ***
  PERM_SYNC_SHAREPOINT_PRIVATE_KEY: ***
  PERM_SYNC_SHAREPOINT_CERTIFICATE_PASSWORD: ***
  PERM_SYNC_SHAREPOINT_DIRECTORY_ID: ***
  GITHUB_REPO_NAME: ***/onyx
Error: One or more upstream jobs failed or were cancelled.

10 jobs failed running on non-Blacksmith runners.


Summary: 2 successful workflows, 7 failed workflows

Last updated: 2025-09-23 21:40:30 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant