fix(github): Revert cache being turned off #5487
Merged
+0
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Greptile Overview
Summary
This PR reverts a previous change that disabled Docker layer caching in the GitHub Actions integration test workflows. The change removes no-cache: true from six Docker build steps across both the standard and MIT integration test workflows.
Key changes:
- Re-enables Docker layer caching for backend, model server, and integration test image builds
- Should improve build performance by allowing Docker to reuse unchanged layers
- Affects both
pr-integration-tests.ymlandpr-mit-integration-tests.ymlworkflows - No functional changes to test execution, only build optimization
This is a test PR to investigate whether caching was the root cause of integration test failures, as mentioned in the PR description.
Confidence Score: 5/5
- This PR is safe to merge with minimal risk
- Score reflects the low-risk nature of this change - it only reverts Docker cache settings and has no impact on application logic or test execution. Re-enabling caching is standard practice and should improve build performance.
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| .github/workflows/pr-integration-tests.yml | 5/5 | Removed no-cache: true from three Docker build steps to re-enable caching for better build performance |
| .github/workflows/pr-mit-integration-tests.yml | 5/5 | Removed no-cache: true from three Docker build steps to re-enable caching for better build performance |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant GHA as GitHub Actions
participant Registry as Private Registry
participant Docker as Docker Buildx
Note over Dev,Docker: PR Integration Tests Workflow
Dev->>GHA: Push PR / Merge group event
GHA->>GHA: discover-test-dirs
GHA->>GHA: prepare-build (OpenAPI generation)
par Build Backend Image
GHA->>Docker: Setup Docker Buildx
GHA->>Registry: Login to private registry
Docker->>Docker: Build backend image (WITH cache enabled)
Docker->>Registry: Push backend image
and Build Model Server Image
GHA->>Docker: Setup Docker Buildx
GHA->>Registry: Login to private registry
Docker->>Docker: Build model server image (WITH cache enabled)
Docker->>Registry: Push model server image
and Build Integration Image
GHA->>Docker: Setup Docker Buildx
GHA->>Registry: Login to private registry
Docker->>Docker: Build integration image (WITH cache enabled)
Docker->>Registry: Push integration image
end
GHA->>GHA: Run integration tests using built images
Note over Docker: Cache Change Impact
Note over Docker: Previously: no-cache: true (disabled caching)
Note over Docker: Now: cache enabled (faster subsequent builds)
2 files reviewed, no comments
|
4 Jobs Failed: Run Integration Tests v2 / integration-tests (connector_job_tests/sharepoint, connector-sharepoint) failed on "Wait for service to be ready"Run Integration Tests v2 / integration-tests (tests/playwright, tests-playwright) failed on "Unknown Step"Run Integration Tests v2 / required failed on "Run actions/github-script@v7"1 job failed running on non-Blacksmith runners. Summary: 7 successful workflows, 2 failed workflows
Last updated: 2025-09-25 03:05:49 UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Provide a brief description of the changes in this PR]
We are now trying to test that caching is the issue that leads to integration tests being broken. This is a test PR
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
We are testing this with this PR
Additional Options